Skip to content

ext/opcache/ZendAccelerator.c: Restrict MD5 header include to Windows #15418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 14, 2024

As it is only ever used in accel_gen_uname_id() which is Windows only

As it is only ever used in accel_gen_uname_id() which is Windows only
@Girgias Girgias force-pushed the accelerator-header branch from 436a655 to 3bec496 Compare August 14, 2024 23:48
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that has been overlooked when zend_system_id had been split.

(We may want to review the use of md5 here and in zend_system_id. /cc @TimWolla)

Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I also didn't check for the ext/standard extension back then at GH-14682

@Girgias Girgias merged commit 3e226af into php:master Aug 15, 2024
10 checks passed
@Girgias Girgias deleted the accelerator-header branch August 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants